Skip to content

Conversation

@soul2zimate
Copy link

(cherry picked from commit 1f08501)

upstream PR: #8700

issue: https://hibernate.atlassian.net/browse/HHH-18229

[Backport HHH-18229 fix to downstream 6.2 branch]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@mbellade
Copy link
Member

mbellade commented Feb 6, 2025

@soul2zimate it looks like compilation is failing, could you please check?

@soul2zimate
Copy link
Author

@soul2zimate it looks like compilation is failing, could you please check?

sure, missed the Nullable import statement for some classes. I have updated the PR.

@mbellade
Copy link
Member

mbellade commented Feb 7, 2025

@soul2zimate looks like the build is still failing, are you going to look into it?

@soul2zimate
Copy link
Author

soul2zimate commented Feb 7, 2025

@soul2zimate looks like the build is still failing, are you going to look into it?

sorry @mbladel I am on an unexpected PTO and I don't have my laptop nearby. There is no compilation error but it seems there are failed tests which I don't understand why. I can only investigate them next Monday.

@mbellade
Copy link
Member

mbellade commented Feb 7, 2025

No problem, just let us know if you need help or if you won't be able to look into it yourself we can always give it a try.

Copy link
Author

@soul2zimate soul2zimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mbladel, The Tests / Build/ ... checks are passed. Can you check if this is good for you ?

@mbellade mbellade added the 6.2 label Feb 10, 2025
Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks @soul2zimate!

@beikov beikov merged commit a894991 into hibernate:6.2 Mar 6, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants